Fix & modularize DataPackage fetch methods #2613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored the fetch method in DataPackage to return a Promise and handle options correctly. - Added detailed documentation for fetch method usage. - Improved error handling and retry logic for fetch method. - Added unit tests for DataPackage fetch method to ensure proper functionality. - Fixes the issue of a new resource map ID not being created on update Closes #2607
- Update and add corresponding unit tests Issue #2607
|
@vchendrix I was thinking about this and wonder if we should have an AppModel setting for the fetch timeout limit per file. Or if there's not one set, treat it as no timeout. What do you think? |
@robyngit sounds good |
|
@robyngit Sorry it took so long for me to review. I didn't see this. Lookint at it now. |
Default to never timing out, but allow setting a timeout in the appModel Issue #2607
- In editor, if a file fails to fetch ever after multiple retries, show an error message. Includes when there is a timeout and the file takes too long to fetch. - If the EML fails to fetch, show an error message in the metadata section. - The error styling is basic but better than showing a spinner forever. Issue #2607
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of @vchendrix changes in PR #2608