Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improves DataPackage fetch method #2608

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: improves DataPackage fetch method #2608

wants to merge 1 commit into from

Conversation

vchendrix
Copy link
Collaborator

  • Refactored the fetch method in DataPackage to return a Promise and handle options correctly.
  • Added detailed documentation for fetch method usage.
  • Improved error handling and retry logic for fetch method.
  • Added unit tests for DataPackage fetch method to ensure proper functionality.
  • Fixes the issue of a new resource map ID not being created on update

Closes #2607

@vchendrix
fix: improves DataPackage fetch method
d85318d 
- Refactored the fetch method in DataPackage to return a Promise and handle options correctly.
- Added detailed documentation for fetch method usage.
- Improved error handling and retry logic for fetch method.
- Added unit tests for DataPackage fetch method to ensure proper functionality.
- Fixes the issue of a new resource map ID not being created on update

Closes NCEAS#2607
@robyngit robyngit self-requested a review February 5, 2025 18:13
@robyngit robyngit self-assigned this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robyngit robyngit Awaiting requested review from robyngit

At least 1 approving review is required to merge this pull request.

Assignees

@robyngit robyngit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot replace or remove files for a dataset published with a DOI
2 participants
@vchendrix @robyngit