Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot replace or remove files for a dataset published with a DOI #2607

Open
vchendrix opened this issue Feb 4, 2025 · 1 comment · May be fixed by #2608
Open

Cannot replace or remove files for a dataset published with a DOI #2607

vchendrix opened this issue Feb 4, 2025 · 1 comment · May be fixed by #2608
Labels
bug

Comments

@vchendrix
Copy link
Collaborator

vchendrix commented Feb 4, 2025 •
edited
Loading

Describe the bug

When trying to replace or remove files for a dataset that is already published with a DOI, the operation fails with an error message indicating that the identifier is already used by another object.

Steps to Reproduce

  1. Go to the dataset editor.
  2. Attempt to replace or add files to a dataset with an existing DOI.
  3. See the error message.

Expected behavior

The files should be replaced or added without errors.

Screenshots

If applicable, add screenshots to help explain your problem.
Image

Screencast

Watch the screencast

Additional context

This issue prevents updating datasets that are already published, causing significant disruptions in managing published data.
@vchendrix vchendrix added the bug label Feb 4, 2025
@vchendrix
Copy link
Collaborator Author

This seems to be due to the resource map not loading fully on fetch. I think I may have a fix

vchendrix added a commit to wfsi-data/metacatui that referenced this issue Feb 4, 2025
@vchendrix
fix: Prevent replacement or removal of files for datasets published w…
71730fa 
…ith a DOI

+ Reformats fetchMemberModels method for better readability.
+ Ensures proper handling of fetch options in fetch method.
+ Improves error handling and logging for fetch operations.
+ Adds promise-based resolution for fetch operations to ensure proper flow control.
+ Ensures that the resource map is fully resolved.

Related to NCEAS#2607
vchendrix added a commit to wfsi-data/metacatui that referenced this issue Feb 4, 2025
@vchendrix
fix: Prevent replacement or removal of files for datasets published w…
ed4d766 
…ith a DOI

+ Reformats `DataPackage.fetchMemberModels` method for better readability.
+ Ensures proper handling of `DataPackage.fetch` options in fetch method.
+ Improves error handling and logging for fetch operations.
+ Adds promise-based resolution for fetch operations to ensure proper flow control.
+ Ensures that the resource map is fully resolved.
+ Updates `DataPackage.fetch` documentation to provide examples.

Relates to issue NCEAS#2607
vchendrix added a commit to wfsi-data/metacatui that referenced this issue Feb 4, 2025
@vchendrix
fix: Prevent replacement or removal of files for datasets published w…
9e88926 
…ith a DOI

+ Reformats `DataPackage.fetchMemberModels` method for better readability.
+ Ensures proper handling of `DataPackage.fetch` options in fetch method.
+ Improves error handling and logging for fetch operations.
+ Adds promise-based resolution for fetch operations to ensure proper flow control.
+ Ensures that the resource map is fully resolved.
+ Updates `DataPackage.fetch` documentation to provide examples.

Closes NCEAS#2607
vchendrix added a commit to wfsi-data/metacatui that referenced this issue Feb 5, 2025
@vchendrix
fix: improves DataPackage fetch method
d85318d 
- Refactored the fetch method in DataPackage to return a Promise and handle options correctly.
- Added detailed documentation for fetch method usage.
- Improved error handling and retry logic for fetch method.
- Added unit tests for DataPackage fetch method to ensure proper functionality.
- Fixes the issue of a new resource map ID not being created on update

Closes NCEAS#2607
@vchendrix vchendrix linked a pull request Feb 5, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: improves DataPackage fetch method wfsi-data/metacatui
1 participant
@vchendrix