-
Notifications
You must be signed in to change notification settings - Fork 8
File Filter still not working #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
utensils/Envisaged#14 ok, it may be that the version from the base image is simply too old for that filter. |
@NBprojekt would be really nice if you could update gource somehow. The base image itself is now 3 years old (see https://hub.docker.com/r/utensils/opengl). Note to self: According to https://github.com/acaudwell/Gource#requirements "Gource's display is rendered using OpenGL and requires a 3D accelerated video card to run.". Google only found https://hub.docker.com/r/nvidia/opengl as the only maintained image. Unfortunately (for this project), only Ubuntu and CentOS are available. No alpine. |
@koppor If you want to use the latest one, check out https://github.com/BoundfoxStudios/action-gource I've updated all the base images required to use the latest gource version. |
For the googlers: A more recent opengl docker image is https://github.com/boundfoxstudios/docker-opengl @ManuelRauber Thank you for the reply and your work. I am trying it out now (JabRef/jabref#10056). |
@ManuelRauber Sorry for my inactivity lately. Will update the image and check if the filter work then properly. |
Hi @NBprojekt
Some time ago I've sent you a PR #15 because the check was not correct to see if a file filter is set or not.
However, it's still not working.
I've a running action here with
gource-action
: https://github.com/BoundfoxStudios/community-project/blob/develop/.github/workflows/repository-visualization.ymlAs you can see in the debug log, the filter it recognized: https://github.com/BoundfoxStudios/community-project/actions/runs/4288063582/jobs/7469624333#step:4:53
Unfortunately, the
.meta
files are still visible in the output video.I've also tried different syntaxes in the yaml file for setting the filter:
If I run gource locally with:
gource --file-filter "\.meta$" --key --seconds-per-day 0.5 --auto-skip-seconds 0.1
I don't see the.meta
files in the output.Any idea what can be wrong?
The text was updated successfully, but these errors were encountered: