Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow measurement errors in photometry.DiskIntegratedPhaseFunc.from_obs method #353

Open
3 of 5 tasks
jianyangli opened this issue Jun 30, 2022 · 0 comments
Open
3 of 5 tasks
Assignees
Labels
feature request request for new functionality
Milestone

Comments

@jianyangli
Copy link
Contributor

This is a request for

  • a new feature
  • an enhancement to existing sbpy functionality
  • somethings else: [explain here]

The requested changes will be implemented by

  • me
  • the sbpy developers

High-level concept
sbpy.photometry.DiskIntegratedPhaseFunc provides class method from_obs to fit observational data and retrieve a phase function model. The current implementation doesn't use measurement errors in the fit. This enhancement should allow the use of measurement errors if present in the input.

Explain the relevance to sbpy
Enhancement to existing sbpy class method.

Proposal details
Check the existence of measurement errors in the input, and pass to fitter if present.

Example (pseudo-)code

@jianyangli jianyangli added the feature request request for new functionality label Jun 30, 2022
@jianyangli jianyangli self-assigned this Jun 30, 2022
@jianyangli jianyangli added this to the v0.4 milestone Jun 30, 2022
@mkelley mkelley modified the milestones: v0.4, v0.5 May 31, 2023
@mkelley mkelley modified the milestones: v0.5, v0.6 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request request for new functionality
Projects
None yet
Development

No branches or pull requests

2 participants