-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deepbook SDK] Check user's locked balance before placing order. #17082
Comments
Another thing that could be an improvement is to take an optional I think each function should take an optional |
Hey, thanks for the feedback! We will take care of things on the Move side, but feel free to create a PR on the SDK with the improvement you mentioned. |
I think that it would be an improvement with errors if we check the user's locked balance first and make sure it's more than the amount he's placing an order for because otherwise you get error from
balance
module with an unreadable error message, unless you know know what that error code meant.what do you think? happy to work on it if you think it would be an improvement in the sdk.
The text was updated successfully, but these errors were encountered: