fix(./class/eventManagement/dispatcher/transaction-handler): remove ping transactions (#307)

* fix(./class/eventManagement/dispatcher/transaction-handler): remove ping transactions

* refactor(./class/eventManagement/dispatcher/Transaction-handler): fix shared options

* test(): updated UT

Author: Rossb0b

src/class/eventManagement/dispatcher.class.ts

@@ -778,7 +778,12 @@ export class Dispatcher<T extends GenericEvent = GenericEvent> extends EventEmit
       }
     } as Transaction<"incomer">);
 
-    await this.incomerStore.updateIncomerState(origin);
+    try {
+      await this.incomerStore.updateIncomerState(origin);
+    }
+    catch {
+      // Do Nothing
+    }
 
     this.#logger.info(this.#standardLogFn(
       Object.assign({}, logData, {

src/class/eventManagement/dispatcher/transaction-handler.class.ts

@@ -43,7 +43,6 @@ interface DistributeMainTransactionOptions {
 interface ResolveTransactions {
   incomers: Set<RegisteredIncomer>;
   backupIncomerTransactions: Transactions<"incomer">;
-  dispatcherTransactions: Transactions<"dispatcher">;
 }
 
 interface FindISOIncomerOptions {
@@ -151,10 +150,9 @@ export class TransactionHandler<T extends GenericEvent = GenericEvent> {
         this.backupDispatcherTransactionStore.getTransactions()
       ]);
 
-      let options = {
+      let sharedOptions = {
         incomers,
-        backupIncomerTransactions,
-        dispatcherTransactions
+        backupIncomerTransactions
       };
 
       const mappedBackupDispatcherTransactions = new Map([...backupDispatcherTransactions.entries()]
@@ -167,10 +165,12 @@ export class TransactionHandler<T extends GenericEvent = GenericEvent> {
           return [id, formatted];
         }));
 
-      options = await this.handleBackupIncomerTransactions(options);
+      sharedOptions = await this.handleBackupIncomerTransactions(sharedOptions);
+
+      await this.resolvePingTransactions(dispatcherTransactions);
 
       await this.resolveMainTransactions({
-        ...options,
+        ...sharedOptions,
         dispatcherTransactions: new Map([...dispatcherTransactions, ...mappedBackupDispatcherTransactions])
       });
     }
@@ -414,7 +414,7 @@ export class TransactionHandler<T extends GenericEvent = GenericEvent> {
   }
 
   private async handleBackupIncomerTransactions(options: ResolveTransactions): Promise<ResolveTransactions> {
-    const { incomers, backupIncomerTransactions, dispatcherTransactions } = options;
+    const { incomers, backupIncomerTransactions } = options;
 
     const toResolve = [];
 
@@ -437,7 +437,7 @@ export class TransactionHandler<T extends GenericEvent = GenericEvent> {
 
     await Promise.all(toResolve);
 
-    return { incomers, backupIncomerTransactions, dispatcherTransactions };
+    return { incomers, backupIncomerTransactions };
   }
 
   private findISOIncomer(options: FindISOIncomerOptions) : RegisteredIncomer | undefined {
@@ -474,7 +474,22 @@ export class TransactionHandler<T extends GenericEvent = GenericEvent> {
     ]);
   }
 
-  private async resolveMainTransactions(options: ResolveTransactions) {
+  private async resolvePingTransactions(dispatcherTransactions: Transactions<"dispatcher">) {
+    for (const dispatcherTransaction of dispatcherTransactions.values()) {
+      if (dispatcherTransaction.name === "PING" && dispatcherTransaction.redisMetadata.resolved) {
+        try {
+          await this.incomerStore.updateIncomerState(dispatcherTransaction.redisMetadata.to);
+        }
+        catch {
+          // Do Nothing
+        }
+
+        await this.dispatcherTransactionStore.deleteTransaction(dispatcherTransaction.redisMetadata.transactionId);
+      }
+    }
+  }
+
+  private async resolveMainTransactions(options: ResolveTransactions & { dispatcherTransactions: Transactions<"dispatcher">}) {
     const { incomers, backupIncomerTransactions, dispatcherTransactions } = options;
 
     const toResolve = [];

test/UT/class/eventManagement/dispatcher.spec.ts

@@ -365,13 +365,7 @@ describe("Dispatcher", () => {
 
         const pingTransaction = await dispatcherTransactionStore.getTransactionById(pingTransactionId);
 
-        expect(pingTransaction).toEqual({
-          ...pingTransaction,
-          redisMetadata: {
-            ...pingTransaction?.redisMetadata,
-            resolved: true
-          }
-        });
+        expect(pingTransaction).toEqual(null);
         expect(mockedCheckLastActivity).toHaveBeenCalled();
       });
     });

test/UT/class/eventManagement/handle-inactive-with-backup.spec.ts

@@ -168,6 +168,11 @@ describe("Publishing/exploiting a custom event & inactive incomer", () => {
           // Do nothing
         });
 
+      jest.spyOn(concernedIncomer as any, "handlePing")
+        .mockImplementation(async(opts: any) => {
+          // Do nothing
+        });
+
       secondConcernedIncomer = new Incomer({
         redis,
         subscriber,