Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Make update check opt-in option! #165

Closed
cl3m3c7 opened this issue Apr 1, 2024 · 5 comments 路 Fixed by #168
Closed

Suggestion: Make update check opt-in option! #165

cl3m3c7 opened this issue Apr 1, 2024 · 5 comments 路 Fixed by #168
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@cl3m3c7
Copy link

cl3m3c7 commented Apr 1, 2024

Hi,
I want to suggest to make update check a settings in the prefs (enabled by default?) because if you have slow a connection or no internet but connected to the network 馃槙, blender freezes until the plugin gets a result back!

@Mustard2
Copy link
Owner

Mustard2 commented Apr 4, 2024

Upsi, didn't think about it.
I'll surely make it optional in the next update.

@Mustard2 Mustard2 self-assigned this Apr 4, 2024
@Mustard2 Mustard2 added bug Something isn't working enhancement New feature or request labels Apr 4, 2024
@cl3m3c7
Copy link
Author

cl3m3c7 commented Apr 5, 2024

thanks, I know it's very specific and rare case since people nowadays have good internet, but yeah it's nice to have!

@Mustard2
Copy link
Owner

Mustard2 commented Apr 22, 2024

I perfectly agree, I'll ake the updates check optional and disabled by default :)

It took a bit more than expected because of how the python environment of addons is added to Blender. Long story short, this needed an handler.

@cl3m3c7
Copy link
Author

cl3m3c7 commented Apr 23, 2024

I perfectly agree, I'll (m)ake the updates check optional and disabled by default :)

in my humble opinion, I think it should be enabled by default because 99% of the time this shouldn't create any problem, but in those rare cases where the bottleneck occurs, one can choose to disable it!

@Mustard2
Copy link
Owner

Yes, I think I'll make it enabled by default in the end. :)

@Mustard2 Mustard2 linked a pull request Apr 28, 2024 that will close this issue
Mustard2 added a commit that referenced this issue May 25, 2024
* App version check has been rewritten to be optional (#165)
* Fix #166 (pull request #169 by @cl3m3c7 )
* Fix for #171
* Other small bug fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants