Skip to content
This repository has been archived by the owner on Jan 5, 2021. It is now read-only.

Write proper tests #173

Open
Varunram opened this issue Feb 19, 2018 · 10 comments
Open

Write proper tests #173

Varunram opened this issue Feb 19, 2018 · 10 comments
Labels
2.0 Desired changes towards wallet 2.0 10000MC 20000MC need info

Comments

@Varunram
Copy link
Contributor

With the increasing number of facilities that the wallet offers, it becomes critical not to break certain features when introducing new ones. Towards this, we have to write test cases and test them using a CI (Travis/Circle would be fine I guess, Jenkins is also OK). Ideas welcome

@Varunram
Copy link
Contributor Author

Upgrading the bounty on this one to 20k MC, which can be expanded upon in the future.

@etaletai13
Copy link
Contributor

On it. I hope somebody beats me to it though.

@etaletai13
Copy link
Contributor

Okay, if all goes according to plan, I should be able to hook this nicely into a further minor bump after the yarn patch; so that yarn test is all you need to do; and I'll TRY to make a little menu for adding a new test. I have no idea why the ease of contributing is so important to me; but it really is.

@movingelectrons
Copy link
Contributor

tests are very, very important. it has been a few years sense i have written any good ones, last ones i did i used shoulda on RoR, along with a more complex suite that actually ran client side javascript (sometimes in a browser even).

does anyone have any specific plans for what we are going to do here? at least as far as which testing frameworks/suites/whatever they should be callled

@etaletai13
Copy link
Contributor

@movingelectrons I was considering doing scripted browser tests, considering that it does run on a browser's core.

@movingelectrons
Copy link
Contributor

do you know if it is possible to start the app on the actual chrome browser?

@movingelectrons
Copy link
Contributor

I wanted to know if its easy to run it in a browser, or at very least the UI, so I can use the developer tools in chrome to tweak the css and html. Doing it that way will save me a good chunk of time for certain.

@etaletai13
Copy link
Contributor

@movingelectrons As far as I'm aware - for now - there's just the dev tools in the sdk version of nw.

@Varunram
Copy link
Contributor Author

Bumping up the bounty on this one to 30k MC for anyone that manages to get an integrated framework ready.

@Varunram Varunram added 10000MC Bounty 2.0 Desired changes towards wallet 2.0 and removed release-1.5 labels Jun 24, 2018
@etaletai13
Copy link
Contributor

Chai and Mocha, it'll do the job. I'll start finally.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.0 Desired changes towards wallet 2.0 10000MC 20000MC need info
Projects
None yet
Development

No branches or pull requests

3 participants