Skip to content

Commit 08b3358

Browse files
committed
UI constants and default variables modifications
1 parent 2bd6862 commit 08b3358

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/ui/ui.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ UiManager::UiManager(EmbreeInterface& embreeInterface, Trackball& camera, Config
3838
{}
3939

4040
void UiManager::draw() {
41-
ImGui::Begin("Seminar Implementation");
41+
ImGui::Begin("RMIS Implementation");
4242
ImGui::BeginTabBar("Options");
4343
if (ImGui::BeginTabItem("Ray Tracing")) {
4444
drawRayTracingTab();
@@ -304,7 +304,7 @@ void UiManager::drawRayTracingParams() {
304304
ImGui::Text("Common");
305305
ImGui::SliderInt("Samples per reservoir", (int*) &config.features.numSamplesInReservoir, 1, 32);
306306
ImGui::SliderInt("Canonical sample count", (int*) &config.features.initialLightSamples, 1, 256);
307-
ImGui::SliderInt("Neighbours to sample", (int*) &config.features.numNeighboursToSample, 1, 10);
307+
ImGui::SliderInt("Neighbours to sample", (int*) &config.features.numNeighboursToSample, 0, 10);
308308
ImGui::SliderInt("Spatial resample radius", (int*) &config.features.spatialResampleRadius, 1, 30);
309309

310310
ImGui::Spacing();

src/utils/common.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,13 @@ struct Features {
108108
uint32_t spatialResampleRadius = 10U;
109109

110110
// Neighbour selection heuristics controls
111-
bool neighbourSameGeometry = false;
111+
bool neighbourSameGeometry = true;
112112
float neighbourMaxDepthDifferenceFraction = 0.10f;
113113
float neighbourMaxNormalAngleDifferenceRadians = 0.436332f;
114114

115115
// R-MIS/R-OMIS parameter(s)
116116
uint32_t maxIterationsMIS = 5U;
117-
NeighbourSelectionStrategy neighbourSelectionStrategy = NeighbourSelectionStrategy::Random;
117+
NeighbourSelectionStrategy neighbourSelectionStrategy = NeighbourSelectionStrategy::Similar;
118118
MISWeightRMIS misWeightRMIS = MISWeightRMIS::Equal;
119119
bool useProgressiveROMIS = false;
120120
uint32_t progressiveUpdateMod = 1U;

0 commit comments

Comments
 (0)