Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Undo Loop function truncates window size for windows that were not completely on the screen #347

Closed
2 tasks done
adly42 opened this issue May 1, 2024 · 1 comment · Fixed by #357
Closed
2 tasks done
Assignees
Labels
bug Something isn't working

Comments

@adly42
Copy link

adly42 commented May 1, 2024

Bug Description

If a window is half off the screen, then looped to a different position, using the Undo Loop function does not restore the window to its original size. Whatever part of the window that was visible on the screen will become the new window's dimensions.

Steps To Reproduce

  1. Create a new window of any Loop-supported program
  2. Move the window so that part of the window is off screen
  3. Use Loop to move the window to a new position
  4. Undo Loop to revert the window to its offscreen position and dimensions
  5. (Optional) Click and drag the window to see that its dimensions were truncated by the screen's boundaries

Expected Behavior

The Undo Loop function should restore the window's previous size and dimensions, even if part of it is off screen.

Actual Behavior

The Undo Loop function truncates a window's dimensions for edges that leave the bounds of the screen (i.e., go offscreen).

Screenshots

Undo.Loop.Bug.mov

MacOS Version

Sonoma 14.0

Loop Version

Version 1.0.0-beta.15 (817)

Additional Context

No response

Final Checks

  • My issue title is descriptive
  • This is a single bug (multiple bugs should be reported individually)
@adly42 adly42 added the bug Something isn't working label May 1, 2024
@MrKai77
Copy link
Owner

MrKai77 commented May 1, 2024

This seems to be caused by Loop still applying window padding (of 0 pt in this case) to the window, which causes it to be cropped to fit on the screen. Will fix!

@MrKai77 MrKai77 self-assigned this May 1, 2024
@MrKai77 MrKai77 linked a pull request May 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants