Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to shift the timestamp of each comment to match the video #4

Closed
Mr-Quin opened this issue Mar 16, 2024 · 3 comments
Closed

Option to shift the timestamp of each comment to match the video #4

Mr-Quin opened this issue Mar 16, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Mr-Quin
Copy link
Owner

Mr-Quin commented Mar 16, 2024

Sometimes the timestamp of video being played may not match exactly with the timestamp of the comments. For example a video release may have a longer intro than the one where the comments are sourced from, resulting in each comment showing up earlier than they should.
An option to fast-forward or delay the comments should be added.

@Mr-Quin Mr-Quin added the enhancement New feature or request label Mar 16, 2024
@Mr-Quin Mr-Quin added this to the 1.0.0 release milestone Mar 16, 2024
@Mr-Quin Mr-Quin self-assigned this Mar 16, 2024
@Mr-Quin
Copy link
Owner Author

Mr-Quin commented Mar 18, 2024

Might want to find another danmkau renderer that supports this, or implement one myself. Implementing this outside of the renderer is not good UX.

@Mr-Quin
Copy link
Owner Author

Mr-Quin commented Mar 28, 2024

Added the options in 4f8c75d

@Mr-Quin
Copy link
Owner Author

Mr-Quin commented Mar 28, 2024

Problem with danmaku engine continued in #9

@Mr-Quin Mr-Quin closed this as completed Mar 28, 2024
@Mr-Quin Mr-Quin removed this from the 1.0.0 release milestone Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant