Improve performance of discovery service

The listener was registered way too many times and would duplicate the amount of work needed when discovering devices. It could grow exponentially worse.

Author: Moustachauve

app/src/main/java/ca/cgagnier/wlednativeandroid/MainActivity.kt

@@ -98,11 +98,15 @@ class MainActivity : AutoDiscoveryActivity, DeviceDiscovery.DeviceDiscoveredList
     }
 
     override fun onResume() {
+        (application as DevicesApplication).deviceDiscovery
+            .registerDeviceDiscoveredListener(this)
         startAutoDiscovery()
         super.onResume()
     }
 
     override fun onPause() {
+        (application as DevicesApplication).deviceDiscovery
+            .unregisterDeviceDiscoveredListener(this)
         stopAutoDiscovery()
         super.onPause()
     }
@@ -113,8 +117,6 @@ class MainActivity : AutoDiscoveryActivity, DeviceDiscovery.DeviceDiscoveredList
             return
         }
         Log.i(TAG, "Starting auto discovery")
-        (application as DevicesApplication).deviceDiscovery
-            .registerDeviceDiscoveredListener(this)
         (application as DevicesApplication).deviceDiscovery.start()
         autoDiscoveryLoopHandler.postDelayed({
             runOnUiThread {
@@ -126,8 +128,6 @@ class MainActivity : AutoDiscoveryActivity, DeviceDiscovery.DeviceDiscoveredList
     override fun stopAutoDiscovery() {
         Log.i(TAG, "Stopping auto discovery")
         autoDiscoveryLoopHandler.removeCallbacksAndMessages(null)
-        (application as DevicesApplication).deviceDiscovery
-            .unregisterDeviceDiscoveredListener(this)
         (application as DevicesApplication).deviceDiscovery.stop()
     }
 

app/src/main/java/ca/cgagnier/wlednativeandroid/service/DeviceDiscovery.kt

@@ -55,7 +55,7 @@ class DeviceDiscovery(val context: Context) {
             }
 
             override fun onDiscoveryStarted(serviceType: String?) {
-                Log.d(TAG, "Service discovery started")
+                Log.d(TAG, "Service discovery started: $serviceType")
             }
 
             override fun onDiscoveryStopped(serviceType: String?) {
@@ -162,7 +162,7 @@ class DeviceDiscovery(val context: Context) {
         const val TAG = "DEVICE_DISCOVERY"
         const val SERVICE_TYPE = "_wled._tcp."
 
-        const val DEFAULT_WLED_AP_IP = "4.3.2.1"
+        private const val DEFAULT_WLED_AP_IP = "4.3.2.1"
 
 
         @SuppressLint("WifiManagerPotentialLeak")