Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unable to play FLAC with missing cover art mimetype #308

Open
FaridZelli opened this issue Dec 2, 2023 · 3 comments
Open

[BUG] Unable to play FLAC with missing cover art mimetype #308

FaridZelli opened this issue Dec 2, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@FaridZelli
Copy link

Describe the bug:
Moosync skips FLAC files that don't specify a cover art mimetype. Does not apply to ID3/MP3.

Steps to reproduce the behavior:

  1. Use any FLAC with front cover art
  2. Blank out the cover art mimetype in any tag editor (e.g. Kid3)

Expected behavior:
The song should play normally.

  • OS: openSUSE Tumbleweed
  • Version 10.2.0 (Flatpak)

Additional context:
I was unable to reproduce this issue with any other player (WMP, VLC, MusicBee).

Screenshots
Screenshot from 2023-12-02 23-10-43
Screenshot from 2023-12-02 23-11-10
Screenshot from 2023-12-02 23-18-10

@FaridZelli FaridZelli added the bug Something isn't working label Dec 2, 2023
@Ovenoboyo
Copy link
Contributor

Could you send me the codec information for this file? It seems unlikely that its failing to play due to missing cover art

@FaridZelli
Copy link
Author

It seems unlikely that its failing to play due to missing cover art

Yeah it's a weird one, I think it could be a problem with ffmpeg. It's not uncommon for Vorbis tags to be missing the cover art mimetype field. Most players simply ignore it.

Here's the output from ffprobe:

ffprobe version N-67885-gcc86343b96-static https://johnvansickle.com/ffmpeg/  Copyright (c) 2007-2023 the FFmpeg developers
  built with gcc 8 (Debian 8.3.0-6)
  configuration: --enable-gpl --enable-version3 --enable-static --disable-debug --disable-ffplay --disable-indev=sndio --disable-outdev=sndio --cc=gcc --enable-fontconfig --enable-frei0r --enable-gnutls --enable-gmp --enable-libgme --enable-gray --enable-libaom --enable-libfribidi --enable-libass --enable-libvmaf --enable-libfreetype --enable-libmp3lame --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-librubberband --enable-libsoxr --enable-libspeex --enable-libsrt --enable-libvorbis --enable-libopus --enable-libtheora --enable-libvidstab --enable-libvo-amrwbenc --enable-libvpx --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxml2 --enable-libdav1d --enable-libxvid --enable-libzvbi --enable-libzimg
  libavutil      58. 32.100 / 58. 32.100
  libavcodec     60. 35.100 / 60. 35.100
  libavformat    60. 18.100 / 60. 18.100
  libavdevice    60.  4.100 / 60.  4.100
  libavfilter     9. 13.100 /  9. 13.100
  libswscale      7.  6.100 /  7.  6.100
  libswresample   4. 13.100 /  4. 13.100
  libpostproc    57.  4.100 / 57.  4.100
[flac @ 0x7cdb200] Could not read mimetype from an attached picture.
Input #0, flac, from './Rationale - Tethered.flac':
  Metadata:
    artist          : Rationale
    title           : Tethered
    date            : 2017-02-10
    album           : Vessels
    track           : 4
    disc            : 1
    genre           : Alternative & Pop
    album_artist    : Rationale
    composer        : Tinashé Fazakerley
    bpm             : 112.04
    length          : 206
    organization    : Warner Records/Best Laid Plans
    isrc            : GBAHT1600493
    replaygain_*_gain: -9.1
  Duration: 00:03:26.25, start: 0.000000, bitrate: 732 kb/s
  Stream #0:0: Audio: flac, 44100 Hz, stereo, s16
[STREAM]
index=0
codec_name=flac
codec_long_name=FLAC (Free Lossless Audio Codec)
profile=unknown
codec_type=audio
codec_tag_string=[0][0][0][0]
codec_tag=0x0000
sample_fmt=s16
sample_rate=44100
channels=2
channel_layout=stereo
bits_per_sample=0
initial_padding=0
id=N/A
r_frame_rate=0/0
avg_frame_rate=0/0
time_base=1/44100
start_pts=0
start_time=0.000000
duration_ts=9095625
duration=206.250000
bit_rate=N/A
max_bit_rate=N/A
bits_per_raw_sample=16
nb_frames=N/A
nb_read_frames=N/A
nb_read_packets=N/A
extradata_size=34
DISPOSITION:default=0
DISPOSITION:dub=0
DISPOSITION:original=0
DISPOSITION:comment=0
DISPOSITION:lyrics=0
DISPOSITION:karaoke=0
DISPOSITION:forced=0
DISPOSITION:hearing_impaired=0
DISPOSITION:visual_impaired=0
DISPOSITION:clean_effects=0
DISPOSITION:attached_pic=0
DISPOSITION:timed_thumbnails=0
DISPOSITION:non_diegetic=0
DISPOSITION:captions=0
DISPOSITION:descriptions=0
DISPOSITION:metadata=0
DISPOSITION:dependent=0
DISPOSITION:still_image=0
[/STREAM]

@Ovenoboyo
Copy link
Contributor

Ovenoboyo commented Dec 17, 2023

You're right, it does indeed fail to play the audio if the mime-type is missing.
Though it seems its an issue with chromium rather than this app. I tried opening an audio file with missing image mime-type in chromium and even it can't play it. I'd suggest opening up an issue on the chromium bug tracker

I hope to add support for playing audio outside of electron in coming few days which should solve this issue in Moosync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants