Support TABLESAMPLE clause in a columnstore table

[ktny]

What feature are you requesting?

create table t1 (num int) using columnstore;
insert into t1 select i from generate_series(1, 10000) s(i);
select * from t1 tablesample system(10);

ERROR:  (PGDuckDB/CreatePlan) Prepared query returned an error: 'Parser Error: Sample method System cannot be used with a discrete sample count, either switch to reservoir sampling or use a sample_size

Why are you requesting this feature?

The TABLESAMPLE clause is useful for sampling from large tables, and I often use it.

What is your proposed implementation for this feature?

No response

[dpxcc]

Thanks for the feature request!
The issue arises from syntax differences in TABLESAMPLE clause between Postgres and DuckDB: https://duckdb.org/docs/sql/samples.html
We could potentially modify pgduckdb_get_querydef() to bridge the syntax differences

[dpxcc]

Filed a feature request upstream: duckdb/pg_duckdb#429