Skip to content

Replacing declarations with synthesized ones should be clarified #250

@PathogenDavid

Description

@PathogenDavid

Some types like ExternallyDefinedTypeDeclaration provide an explicit overload which use the Roslyn-synthesized TranslatedDeclaration copy constructor to shadow existing declarations, while with others (IE: TranslatedEnum) you must manually populate ReplacedDeclarations.

Both feel differing degrees of wrong, and forgetting to do this breaks type references. (EG: When replacing a typedef with a sythesized enum as with PotAudioNet.Generator.MacroTransformation.)

This should be revisited and potentially clarified. I think I accidentally went two different directions with this at some point in a way that's causing confusion for me now 😅

Metadata

Metadata

Assignees

No one assigned

    Labels

    Concept-ApiClarityIssues for improving the clarity of the Biohazrd API

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions