Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special consideration for DirectoryInfo #22

Open
dyster opened this issue Feb 23, 2024 · 2 comments
Open

Special consideration for DirectoryInfo #22

dyster opened this issue Feb 23, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dyster
Copy link

dyster commented Feb 23, 2024

Dump() does print out DirectoryInfo object but the recursive nature of the references (JsonSerializer just fails on it so that's good!) makes a few references up or down the directory tree make the panels start appearing very squashed.
I don't know if it is the aim of Dumpify to remain generic for all objects of if special consideration be given for certain types?
If so I think there are many improvements that could be made for DirInfo, like not printing all info for recursive reference and just the dirname, maybe put it in a tree instead of nested panels etc..

@dyster
Copy link
Author

dyster commented Feb 23, 2024

And FileInfo, FileSystemInfo etc

@MoaidHathot
Copy link
Owner

Hi, thanks for the suggestion!
I just tried to dump DirectoryInfo and I agree, it isn't great. I do treat some objects differently, and it will be easy to custom handle DirectoryInfo, FileInfo, etc..., we just need to figure out which properties are required and which are not.

@MoaidHathot MoaidHathot self-assigned this Feb 23, 2024
@MoaidHathot MoaidHathot added enhancement New feature or request good first issue Good for newcomers labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants