Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light and dark modes #210

Open
MitMaro opened this issue Dec 29, 2019 · 1 comment
Open

Add light and dark modes #210

MitMaro opened this issue Dec 29, 2019 · 1 comment
Labels
enhancement investigate Requires investigation

Comments

@MitMaro
Copy link
Owner

MitMaro commented Dec 29, 2019

Feature Request

Terminal emulators default to either a light background based theme or a dark background based theme. This tool assumes a dark background based terminal, but this isn't true for all terminals. For example the default terminal on Linux Mint:

girt-white-background

It is currently possible to modify the colors to ensure that the text is visible on a white terminal, but it should be possible to switch the rebase editor to a light/dark mode that would provide a better set of defaults.

This should also be configurable via an environment variable, so that systems that switch light/dark mode based on the time of day can dynamically change the mode.

The color configuration should be updated to optionally take two colors per configuration.

@MitMaro MitMaro self-assigned this Dec 29, 2019
@nickolay
Copy link
Contributor

nickolay commented Aug 16, 2020

For me, on iTerm2 with the built-in "Light background" preset, the tool looks fine, except for the "selected" line, which is displayed as black-on-dark-grey. The only config that's needed to fix it is:

[interactive-rebase-tool]
selectedBackgroundColor = 240,240,240

UPD: https://github.com/dalance/termbg "A Rust library for terminal background color detection." might be useful.

@MitMaro MitMaro removed their assignment Feb 5, 2021
@MitMaro MitMaro moved this to Triage in GIRT Project Mar 26, 2022
@MitMaro MitMaro added the investigate Requires investigation label Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement investigate Requires investigation
Projects
Status: Triage
Development

No branches or pull requests

2 participants