Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make it work with PM 3.11.x #25

Closed
Invy55 opened this issue Dec 31, 2019 · 1 comment
Closed

Please make it work with PM 3.11.x #25

Invy55 opened this issue Dec 31, 2019 · 1 comment

Comments

@Invy55
Copy link

Invy55 commented Dec 31, 2019

No description provided.

@MlsDmitry
Copy link

MlsDmitry commented Apr 23, 2020

it's work!
If you have the issue that lines not displaying but display name of the scoreboard displays, you can do -> $scoreboard->addEntry($entry, [$p]) without $p it would't displayed.
also you can go to ScoreboardAPI and add this line
if (empty($this->scoreboardViewers[$scoreboard->getObjectiveName()])) return $this->getServer()->getOnlinePlayers();
after this line
if (!isset($this->scoreboardViewers[$scoreboard->getObjectiveName()])) return [];
It's api bug, I haven't pull request it yet. It's logical mistake, because then he(jason) didn't get any entry players he ask for getScoreboardViewers() before add something to this array.

@MisteFr MisteFr closed this as completed Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants