Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a desktop hover menu for programs sections #216

Merged
merged 5 commits into from
Dec 11, 2020
Merged

Conversation

etrepum
Copy link
Member

@etrepum etrepum commented Dec 10, 2020

RE #215

@coramonokandilos
Copy link
Contributor

Looks good! One thing -- is it possible to remove the shadow or make it a little bit less on the top?
Screen Shot 2020-12-10 at 10 28 06 AM

@etrepum
Copy link
Member Author

etrepum commented Dec 11, 2020

We can do whatever we want with the style but I don't quite understand what you want it to look like, can you give me a mockup of what you want?

@coramonokandilos
Copy link
Contributor

I put a screenshot of a mockup I made in the comment I left earlier.
Just for the top of the expanded menu to not have a shadow so it's not as harsh of a jump from the regular nav to the expanded nav. Your example here for reference:
Screen Shot 2020-12-10 at 4 03 42 PM

@etrepum
Copy link
Member Author

etrepum commented Dec 11, 2020

Got it, wasn't clear what the screenshot was since there wasn't much context in the comment

@etrepum etrepum marked this pull request as ready for review December 11, 2020 16:22
@coramonokandilos coramonokandilos merged commit 71548e7 into master Dec 11, 2020
@coramonokandilos coramonokandilos deleted the nav-gh-215 branch December 11, 2020 18:21
@etrepum etrepum linked an issue Dec 11, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multi-level navigation with desktop hover for Programs menu
2 participants