Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rideable entities #561

Open
BenCheung0422 opened this issue Aug 22, 2023 · 5 comments · May be fixed by #592
Open

Rideable entities #561

BenCheung0422 opened this issue Aug 22, 2023 · 5 comments · May be fixed by #592
Labels
Improvement Ideas for changes to features or content.

Comments

@BenCheung0422
Copy link
Member

BenCheung0422 commented Aug 22, 2023

Is your feature request related to a problem? Please describe.
It seems that boat and horse may be added in the future, so this feature is important.
If we need to implement the logic and idea correctly and completely, this feature (https://minecraft.fandom.com/wiki/Riding) would still be needed, instead of just targeting implementing the feature in the simplest and easiest way. This behaviour and direction have been used for a long time with Load and the static class structures as examples. (Taken from a Discord message in the boat post.)

Describe the solution you'd like
We should implement the riding feature. If boat is implemented with Boat as in #134, it would not be a standardized logic, i.e. not implemented completely and correctly. There should be a map (a BiMap is recommended.) mapping the entity riding relationships. The map should be stored in a separated file in save. When the save system is rewritten, the data of the passenger can be instead recorded within an entity recursively instead of using a separated mapping. The position of the passenger is led by the mount and the boat is controlled by the player when being ridden. An entity can only be ridden and/or riding not more than one entity not being ridden by the entity itself.

@BenCheung0422 BenCheung0422 added the Improvement Ideas for changes to features or content. label Aug 22, 2023
@DevWolf31
Copy link

This is fine.

@BenCheung0422
Copy link
Member Author

Also, #287 mentioned ridable entity, so this could be an important feature, and #557 mentioned minecart, which might be possible and more realizable if the whole entity moving control system is rewritten.

@BenCheung0422 BenCheung0422 changed the title Entity riding feature General entity riding feature Aug 25, 2024
@JamesTDG
Copy link

Issue #287 for context:

Ridable entities:
Simply put, have a mob saddle, tame certain entities with certain items (wheat for cows/sheep, carrots for pigs), once tamed, the player just uses the use key while holding the saddle on the entity to ride it. (For logistics, it would be easier just to have the saddle texture just be a layer to save time on texture making)

And a refined version:

  • Make all passive quadrupedal entities support the saddle
  • Animals MUST tamed with their requisite food item before the saddle item can work on them. Message should pop up in chat with "This animal must be tamed to ride them"
  • Saddle should exist as a separate texture that should be overlaid upon entities, rather than increase the number of unique frames a texture pack developer needs to make.
  • Different entities could provide different bonuses for riding:
    Cows: Can carry items
    Sheep: Move faster on rocky terrain (in reference to mountain goats), or portable bed
    Pigs: TBD
    Horses (when added): Increased general speed. Should not be greater than electric locomotives, as to not harm viability for issue Logic circuits/control circuit system #694

@BenCheung0422
Copy link
Member Author

Thanks for organizing. And for ridable mobs, they would require some biological needs, so may differ more from machines.

@JamesTDG
Copy link

Thanks for organizing. And for ridable mobs, they would require some biological needs, so may differ more from machines.

Just, make sure to balance it, we don't want to make horses OP, or too inconvenient to maintain.

@Makkkkus Makkkkus changed the title General entity riding feature Rideable entities Dec 5, 2024
@Makkkkus Makkkkus linked a pull request Dec 5, 2024 that will close this issue
@Makkkkus Makkkkus moved this from Todo to In Progress in Development board Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Ideas for changes to features or content.
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants