Add Host header (swift-server#650) (swift-server#651)

MihaelIsaev · Dec 6, 2022 · 49abfc3 · 49abfc3
1 parent 2859c10
commit 49abfc3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/Sources/AsyncHTTPClient/ConnectionPool/ChannelHandler/HTTP1ProxyConnectHandler.swift b/Sources/AsyncHTTPClient/ConnectionPool/ChannelHandler/HTTP1ProxyConnectHandler.swift
@@ -155,6 +155,7 @@ final class HTTP1ProxyConnectHandler: ChannelDuplexHandler, RemovableChannelHand
             method: .CONNECT,
             uri: "\(self.targetHost):\(self.targetPort)"
         )
+        head.headers.replaceOrAdd(name: "host", value: "\(self.targetHost)")
         if let authorization = self.proxyAuthorization {
             head.headers.replaceOrAdd(name: "proxy-authorization", value: authorization.headerValue)
         }

diff --git a/Tests/AsyncHTTPClientTests/HTTP1ProxyConnectHandlerTests.swift b/Tests/AsyncHTTPClientTests/HTTP1ProxyConnectHandlerTests.swift
@@ -43,6 +43,7 @@ class HTTP1ProxyConnectHandlerTests: XCTestCase {
 
         XCTAssertEqual(head.method, .CONNECT)
         XCTAssertEqual(head.uri, "swift.org:443")
+        XCTAssertEqual(head.headers["host"].first, "swift.org")
         XCTAssertNil(head.headers["proxy-authorization"].first)
         XCTAssertEqual(try embedded.readOutbound(as: HTTPClientRequestPart.self), .end(nil))
 
@@ -76,6 +77,7 @@ class HTTP1ProxyConnectHandlerTests: XCTestCase {
 
         XCTAssertEqual(head.method, .CONNECT)
         XCTAssertEqual(head.uri, "swift.org:443")
+        XCTAssertEqual(head.headers["host"].first, "swift.org")
         XCTAssertEqual(head.headers["proxy-authorization"].first, "Basic abc123")
         XCTAssertEqual(try embedded.readOutbound(as: HTTPClientRequestPart.self), .end(nil))
 
@@ -109,6 +111,7 @@ class HTTP1ProxyConnectHandlerTests: XCTestCase {
 
         XCTAssertEqual(head.method, .CONNECT)
         XCTAssertEqual(head.uri, "swift.org:443")
+        XCTAssertEqual(head.headers["host"].first, "swift.org")
         XCTAssertNil(head.headers["proxy-authorization"].first)
         XCTAssertEqual(try embedded.readOutbound(as: HTTPClientRequestPart.self), .end(nil))
 
@@ -148,6 +151,7 @@ class HTTP1ProxyConnectHandlerTests: XCTestCase {
 
         XCTAssertEqual(head.method, .CONNECT)
         XCTAssertEqual(head.uri, "swift.org:443")
+        XCTAssertEqual(head.headers["host"].first, "swift.org")
         XCTAssertNil(head.headers["proxy-authorization"].first)
         XCTAssertEqual(try embedded.readOutbound(as: HTTPClientRequestPart.self), .end(nil))
 
@@ -187,6 +191,7 @@ class HTTP1ProxyConnectHandlerTests: XCTestCase {
 
         XCTAssertEqual(head.method, .CONNECT)
         XCTAssertEqual(head.uri, "swift.org:443")
+        XCTAssertEqual(head.headers["host"].first, "swift.org")
         XCTAssertEqual(try embedded.readOutbound(as: HTTPClientRequestPart.self), .end(nil))
 
         let responseHead = HTTPResponseHead(version: .http1_1, status: .ok)