Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add on-save logic #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add on-save logic #68

wants to merge 1 commit into from

Conversation

MichaelCurrin
Copy link
Owner

@MichaelCurrin MichaelCurrin commented Oct 10, 2021 •
edited
Loading

Resolves #65.

TODO:

  • Make this configurable and default off.
  • Prevent auto-focus on Git pane from other panes.
  • Maybe ignore save on files outside the repo.
  • Multi-repo support.
  • On save when there are no changes and esp outside the repo - avoid error message that there is nothing to generate from.
  • Figure out what to do where there is already a message filled and one saves. Then chore: pull in changes from main in extension.ts becomes chore: update extension.ts pull in changes from main in extension.ts which is bad. At least for the save approach - two flows then?

@MichaelCurrin MichaelCurrin mentioned this pull request Oct 10, 2021
Merged
@devantler
Copy link

devantler commented Jan 6, 2022 •
edited
Loading

Has this been merged yet? And if so how do I enable it?

@MichaelCurrin
Copy link
Owner Author

No #66 was merged and reverted

And #68 is still open because of the items at the top in TODO. I need to figure out at least some of them like the toggle feature before it is safe to merge this without having negative effect on existing use

@MichaelCurrin
Copy link
Owner Author

Sorry life's been hectic the last few months but this is still on my radar to look at.

@MichaelCurrin MichaelCurrin changed the title feat: add on save logic feat: add on-save logic Jun 12, 2022
@callumok2004
Copy link

Any updates on this?

@MichaelCurrin
Copy link
Owner Author

Hi sorry, I moved countries in Sept and haven't had energy for personal development so no progress on this yet

@Foundit3923
Copy link

Interested in this, is it still on the radar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can this be hooked into onSave?
4 participants
@MichaelCurrin @devantler @callumok2004 @Foundit3923