Merge pull request #15 from leo-labs/workaround-wrong-reconnection-logic

Do not throw a SingleProcessingException when smtp sending fails

Author: leo-labs

helm/middlemail/Chart.yaml

@@ -5,7 +5,7 @@ description: Transactional Email
 type: application
 
 version: 1.1.0
-appVersion: 0.4.0
+appVersion: 0.4.1
 
 dependencies:
   - name: rabbitmq

src/MiddleMail.Delivery.Smtp/SmtpDeliverer.cs

@@ -28,8 +28,6 @@ public async Task DeliverAsync(EmailMessage emailMessage) {
 			}
 			try {
 				await sender.SendAsync(mimeMessage);
-			} catch (InvalidOperationException e) {
-				throw new MimeMessageSenderException(emailMessage, mimeMessage, e);
 			} catch (Exception e) {
 				throw new GeneralProcessingException(emailMessage, e);
 			}

tests/Delivery/SmtpDelivererTests.cs

@@ -54,7 +54,7 @@ public async void ThrowsIfBuildFails() {
 			messageSenderMock.Verify(s => s.SendAsync(It.IsAny<MimeMessage>()), Times.Never);
 		}
 
-		[Fact]
+		[Fact (Skip = "Disabled because of workaround in 4cbb493b23b628d262dc6a2429d4e88eaa5d673c")]
 		public async void ThrowsIfInvalidSendFails() {
 			var emailMessage = FakerFactory.EmailMessageFaker.Generate();
 			emailMessage.Subject = MESSAGE_INVALID;