Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an XMLNode class inherited by Tag and the other XML node types #663

Closed
MewPurPur opened this issue Apr 16, 2024 · 0 comments · Fixed by #907
Closed

Implement an XMLNode class inherited by Tag and the other XML node types #663

MewPurPur opened this issue Apr 16, 2024 · 0 comments · Fixed by #907
Assignees
Labels
approved Proposal is approved proposal

Comments

@MewPurPur
Copy link
Owner

MewPurPur commented Apr 16, 2024

XMLNode ---> UnknownXMLNode, CommentXMLNode, CDataXMLNode, TextXMLNode, Tag

This would allow to preserve these things in SVGs. None of them have an effect on rendering, although text nodes can be relevant inside text elements (which aren't supported yet in ThorVG, but still, importing an SVG in our tool shouldn't corrupt it). These would all have their own tag editors in the inspector that allow to edit them.

Prerequisite (or a full solution?) to #548.

@MewPurPur MewPurPur pinned this issue Apr 16, 2024
@MewPurPur MewPurPur changed the title Implement an XMLNode class inherited by Tag, CommentXMLNode, CDataXMLNode, and TextXMLNode Implement an XMLNode class inherited by Tag and the other XML node types Apr 16, 2024
@MewPurPur MewPurPur added approved Proposal is approved and removed challenging labels May 26, 2024
@MewPurPur MewPurPur self-assigned this Sep 2, 2024
@MewPurPur MewPurPur unpinned this issue Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Proposal is approved proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant