New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple `snap_manageAccounts` to `endowment:keyring` #2798

Open

FrederikBolding opened this issue Oct 7, 2024 · 0 comments · May be fixed by #2869

Assignees

Member

FrederikBolding commented Oct 7, 2024 •

edited

Loading

snap_manageAccounts is only supposed to be used by Snaps that implement the keyring API, thus we don't need two separate permissions for this.

We should figure out a way to make snap_manageAccounts not a permission anymore, but instead an RPC method gated by endowment:keyring. E.g.

snaps/packages/snaps-rpc-methods/src/permitted/experimentalProviderRequest.ts

Lines 155 to 157 in a4f3df3

    
           if (!hasPermission(SnapEndowments.EthereumProvider)) { 
        
             return end(rpcErrors.methodNotFound()); 
        
           }

This needs to be done in a backwards compatible way.

The text was updated successfully, but these errors were encountered:

GuillaumeRx self-assigned this

GuillaumeRx linked a pull request

that will close this issue

Move snap_manageAccounts to a gated permitted method #2869

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment