Skip to content

[ESLint] Enable and Fix Disabled ESLint Rules in design-tokens Package #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
9 tasks
georgewrmarshall opened this issue May 11, 2025 · 0 comments
Open
9 tasks
Assignees

Comments

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented May 11, 2025

Description

The design-tokens package should comply with our project's ESLint standards. This issue tracks the work required to ensure the package follows all appropriate linting rules and fix any existing violations.

Current Status

The design-tokens package doesn't have package-specific ESLint rule overrides in our configuration, unlike the design-system-react and design-system-react-native packages. This suggests either:

  1. The package already largely complies with our global ESLint rules, or
  2. We need to evaluate which rules might need adjustments for this package's specific needs.

Implementation Goals

  1. Run a comprehensive lint check specifically for the design-tokens package
  2. Identify any recurring issues that might warrant rule adjustments
  3. Fix all existing lint issues in the codebase
  4. Update configuration if needed after evaluation

Tasks

  • Run ESLint specifically on the design-tokens package to identify any existing issues
  • Categorize issues by rule type (TypeScript, import, general, etc.)
  • Evaluate if any package-specific rule overrides are needed
  • Fix identified issues in the codebase
  • Add appropriate ESLint configuration if necessary
  • Document any decisions about rule adjustments for future reference

Expected Benefits

  • Improved code quality and consistency in the design-tokens package
  • Better alignment with project-wide coding standards
  • Enhanced maintainability and reduced technical debt
  • Fewer potential bugs from code quality issues

Acceptance Criteria

  • The design-tokens package passes ESLint with no errors
  • Documentation is updated if any special ESLint configurations are needed
  • Any exemptions from general rules are properly justified and documented
@georgewrmarshall georgewrmarshall changed the title [ESLint] Enable and Fix Disabled ESLint Rules in design-system-react Package [ESLint] Enable and Fix Disabled ESLint Rules in design-tokens Package May 11, 2025
@georgewrmarshall georgewrmarshall self-assigned this May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant