Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create a branch if there are errors executing the release spec #136

Open
mcmire opened this issue Mar 1, 2024 · 0 comments
Open

Comments

@mcmire
Copy link
Contributor

mcmire commented Mar 1, 2024

If you run the tool and it executes the release spec, but there are errors — for instance, perhaps there are packages you ought to include that you haven't yet — the tool will abort, but it will still create the release branch and place you on it. If you decide to rename this branch or change the branch somehow, then you update the release spec and re-run the tool so that it re-reads the release spec, the tool won't know that changed the branch and will switch you back to the original branch (or recreate it if necessary).

To avoid that from happening, instead of creating the release branch in the first place, the tool should delete it if it detects an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant