Skip to content

Commit 872ea7b

Browse files
authored
Merge pull request #58 from almaslennikov/resource-prefix-fix
Drop validation for resource prefix
2 parents 2a350bd + c00c4bf commit 872ea7b

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

pkg/resources/resources_manager.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ func (rm *resourceManager) ValidateConfigs() error {
120120

121121
for _, conf := range rm.configList {
122122
// check if name contains acceptable characters
123-
if !validResourceNameOrPrefix(conf.ResourceName) {
123+
if !validResourceName(conf.ResourceName) {
124124
return fmt.Errorf("error: resource name \"%s\" contains invalid characters", conf.ResourceName)
125125
}
126126
// check resource names are unique
@@ -129,11 +129,9 @@ func (rm *resourceManager) ValidateConfigs() error {
129129
// resource name already exist
130130
return fmt.Errorf("error: resource name \"%s\" already exists", conf.ResourceName)
131131
}
132-
// If prefix is not configured - use the default one. Otherwise validate if it contains acceptable characters
132+
// If prefix is not configured - use the default one
133133
if conf.ResourcePrefix == "" {
134134
conf.ResourcePrefix = rm.defaultResourcePrefix
135-
} else if !validResourceNameOrPrefix(conf.ResourcePrefix) {
136-
return fmt.Errorf("error: resource prefix \"%s\" contains invalid characters", conf.ResourcePrefix)
137135
}
138136

139137
if conf.RdmaHcaMax < 0 {
@@ -247,7 +245,7 @@ func (rm *resourceManager) RestartAllServers() error {
247245
return nil
248246
}
249247

250-
func validResourceNameOrPrefix(name string) bool {
248+
func validResourceName(name string) bool {
251249
// name regex
252250
var validString = regexp.MustCompile(`^[a-zA-Z0-9_]+$`)
253251
return validString.MatchString(name)

0 commit comments

Comments
 (0)