Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for named bricks #2

Open
McTwist opened this issue Nov 15, 2017 · 3 comments
Open

Add support for named bricks #2

McTwist opened this issue Nov 15, 2017 · 3 comments

Comments

@McTwist
Copy link
Owner

McTwist commented Nov 15, 2017

Currently it is reading the events each time a check for ownership is made. It might seem slow, but actually the event is made to be used alone within a brick. Due to this, it's currently not possible to check if a brick is set as ownership by name elsewhere.

However, as this has been suggested several times, add the ability to do this anyway. There's several approaches and lots of hurdles to cross, and loading bricks is one of them. I'll update this with possible solutions until I find one that might work best.

@McTwist
Copy link
Owner Author

McTwist commented Nov 25, 2017

One way to do it is to package serverCmdAddEvent or fxDTSBrick::addEvent and cache the brick pointed to for further usage. For loading, add the caching for each brick containing the event and a brick name.

Keep in mind that this will still not solve eventually manual adding of events by other Add-Ons. (This issue might be most difficult to solve)

@McTwist
Copy link
Owner Author

McTwist commented Dec 4, 2017

An another way would to use the loading functions to add to a temporary list and apply a cache on the bricks as they are loaded.

@McTwist
Copy link
Owner Author

McTwist commented Dec 8, 2017

An issue was found as the current system wouldn't support it due to the "And" target. Need to check more into this and maybe break it out if people think it's something that needs to be done.

Otherwise, one could either make the "And" an fxDTSBrick, and/or add setApartment for fxDTSBrick as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant