clx: input: english layout

[dkochmanski]

McCLIM input (interactor, listener) are set to the english layout (even if other layout is set on the X window system), so the user can't insert characters like "łęść". If truetype is loaded these characters are rendered without a problem, just can't insert them.

Up-to-date summary is present on the Bounties wiki page.

[dkochmanski]

This bug has assigned 100$ bounty: https://www.bountysource.com/teams/mcclim/bounties

[ailisp]

Is this include the basic text-field and text-editor panels? After switch to a layout such as pl, characters with right alt doesn't work. I also tried es, in es layout, Spanish symbols typed out directly and symbols with shift can work, such as !"·$%&/()= (these are shift+1 2 ... 0), but symbols with right alt ones don't work. May be a awkward solution is to add right alt+character commands in Libraries/Drei/basic-commands.lisp, as input to any text field/editor in the end call com-self-insert in line 514, basic-commands.lisp to insert the character.

[dkochmanski]

it generally affects everything what takes keyboard input in McCLIM. You can render any character, but you can't type them. I suspect it's a trouble in clx (not a backend, but a library)

[gabriel-laddel]

;;; To switch your keyboard layout between Russian & Eng, run the following and
;;; press ALT-SHIFT.
;;;
;;; "setxkbmap -option grp:switpch,grp:alt_shift_toggle,grp:led:scroll us,ru"
;;;
;;; Eval these expressions, switch to russian and enter it into drei - works.
;;; This is only a proof-of-concept, capital letters won't work, and there
;;; are several languages other than Russian that eg, sbcl supports.

(in-package clim-xcommon)

(loop for (a b c)
      in '((DEFINE-KEYSYM :CYRILLIC_SMALL_LETTERF_SOFT_SIGN 1759) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_SOFT_SIGN 1752)
  (DEFINE-KEYSYM :CYRILLIC_CAPITAL_LETTER_SOFT_SIGN 1784) (DEFINE-KEYSYM :CYRILLIC_CAPITAL_LETTER_HARD_SIGN 1791)
  (DEFINE-KEYSYM :CYRILLIC_CAPITAL_LETTER_DZHE 1727) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_DZHE 1711) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_IO 1715)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_IO 1699) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_JE 1720) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_LJE 1721)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_NJE 1722) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_JE 1704) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_LJE 1705)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_NJE 1706) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_YU 1728) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_A 1729)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_BE 1730) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_TSE 1731) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_DE 1732)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_IE 1733) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_EF 1734) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_GHE 1735)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_HA 1736) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_I 1737) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_EL 1740)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_EM 1741) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_EN 1742) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_O 1743)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_PE 1744) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_YA 1745) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_ER 1746)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_ES 1747) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_TE 1748) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_U 1749)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_ZHE 1750) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_VE 1751) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_YERU 1753)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_ZE 1754) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_SHA 1755) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_E 1756)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_SHCHA 1757) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_CHE 1758) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_A 1761)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_BE 1762) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_TSE 1763) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_DE 1764)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_IE 1765) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_EF 1766) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_GHE 1767)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_HA 1768) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_I 1769) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_EL 1772)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_EM 1773) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_EN 1774) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_O 1775)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_PE 1776) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_YA 1777) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_ER 1778)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_ES 1779) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_TE 1780) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_U 1781)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_ZHE 1782) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_VE 1783) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_YERU 1785)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_ZE 1786) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_SHA 1787) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_E 1788)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_SHCHA 1789) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_CHE 1790) (DEFINE-KEYSYM :CYRILLIC_CAPITAL_LETTER_SHORT_I 1770)
  (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_SHORT_I 1738) (DEFINE-KEYSYM :CYRILLIC_CAPITAL_LETTER_KA 1771) (DEFINE-KEYSYM :CYRILLIC_SMALL_LETTER_KA 1739))
      do (setf (gethash c CLIM-XCOMMON::*KEYSYM-NAME-TABLE*) (list b)))

(defun hashtable->list (hashtable)
  (let* ((out)) 
    (maphash (lambda (k v) (push (list k v) out))
         hashtable)
    out))

(loop for (code character) in (MAPCAR (LAMBDA (L) (list (car l) (name-char (symbol-name (CAR (SECOND L))))))
                                      (REMOVE-IF-NOT (LAMBDA (L) (DESTRUCTURING-BIND (A B) L (CL-PPCRE:SCAN "CYRILLIC" (SYMBOL-NAME (CAR B)))))
                                              (HASHTABLE->LIST CLIM-XCOMMON::*KEYSYM-NAME-TABLE*)))
      do (when character ;; we have two codes that don't correspond to anything..
           (setf (gethash code xlib::*keysym->character-map*) (list (list character)))))

[gabriel-laddel]

Oh, an you have to hotpatch XLIB::DISPLAY-KEYBOARD-MAPPING, else new keyboard layouts won't be picked up, in any language.

;;; NOTE, @2016-08-10T01:52:23.738949Z
;;; Fixes https://github.com/robert-strandh/McCLIM/issues/22
(in-package xlib)

(defun display-keyboard-mapping (display)
  (declare (type display display))
  (declare (clx-values (simple-array keysym (display-max-keycode keysyms-per-keycode))))
  (setf (display-keysym-mapping display) (keyboard-mapping display)))

[ailisp]

@gabriel-laddel It works, excellent work!

[gabriel-laddel]

@ailisp Anything else in McCLIM you'd like to see fixed/improved?

[ailisp]

@gabriel-laddel Maybe we will find a way to send a pull issue to clx and automatically add mapping from character representing keywords to unicode characters, then all keyboard layout input may be perfect. a longer term objective is, in fact i'm from China, i would like to add an input method for Chinese, Korean and Japanese. Input method is to show a panel to construct a block word from typing something into a panel. As when use English or Russian, there is no need to use input method so you may not heard of, but if someone want to type hello in Chinese (你好), he must first type "nihao" into the panel and then select correct one from candidate words which have same pronunciation from the panel. So that is much more work than keyboard layout only. I first wonder why, for example, a textbox in GTK+ is able to enable both different kbd layout and input methods. For kbd layout, it directly wrap from x. For input method, it implement a IMEContext mixin based on xim (the official x input method extension) for all text input widgets. So next step I want to add input method feature for McCLIM.

[dkochmanski]

Thanks! I can confirm, that this work for changing keyboard layout (but not keyboard mapping, setxkbmap pl for instance doesn't pick keyboard mapping to issue #\ś on ALT-RIGHT + s).

It's a very good starting point. I'll consult this change with CLX developers after the weekend and hopefully merge this change there.

(NB, as found previously by @gabriel-laddel)
http://stackoverflow.com/questions/35988746/clx-stumpwm-mcclim-keyboard-layout-locked-on-startup

[dkochmanski]

Created a few issues on CLX:
sharplispers/clx#53 (pull request: sharplispers/clx#54)
sharplispers/clx#55 (maybe related: sharplispers/clx#56)

[fiddlerwoaroof]

The change in this commit seems to allow mcclim to detect and handle keymap changes appropriately:

fiddlerwoaroof@a39ec47