-
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider porting nymphcast-player to QML #20
Comments
I have reduced the minimum sizes for the Player window, which should at least help with making it fit better on smaller screens. Minimum width is now 360 px, which assuming 2x scaling on the 720p display on the PinePhone should make it fit properly. As for making the Player UI work better across resolutions, this is something that definitely needs looking at. There are ways to make the current layout into a flow layout: https://doc.qt.io/qt-5/qtwidgets-layouts-flowlayout-example.html Styling the standard widgets using stylesheets will also allow for them to fit better on a specific platform. https://doc.qt.io/Qt-5/stylesheet-syntax.html |
Stylesheet support is now available in the Player. By default The location of the stylesheet file is set in the registry (on Windows) or its equivalent (per the Qt documentation). The idea is to have different stylesheets for different target platforms that can style the GUI for that platform. |
Work on a QML-based version of the NC Player has begun. This version will exist parallel with the current Qt Widget version, and share most of the code. This will leave users free to pick the version that works best for them. I expect to have updates on the progress by next month. |
Hey @MayaPosch do you have any updates? It's been a while since your "next month" statement 😜 |
Sorry about that, there have indeed been a few changes since the beginning of this year :) I have added a stylesheet for the NC Player in the master branch that matches the UI look to that of native Android elements. This generally works, but still needs some testing. Reimplementing the application in QML/C++ turned out to be a lot more hassle, so this seems like a good way forward. I haven't made new APKs yet, but will make something available for testing as soon as the first v0.2-alpha release takes shape. |
Since I'm a postmarketOS developer, I have an interest of using NymphCast on Linux (non-Android) phones. The Nymphcast Player could work great here, if it's UI were made responsive using QML and possibly some responsive library like KDE's Kirigami2.
Currently the experience is... Less than optimal. Apologies for the bad picture, but see how it looks on the PinePhone:
The text was updated successfully, but these errors were encountered: