Skip to content

Inverted definition of allocation and utilization #87

@tfesenbecker

Description

@tfesenbecker

I am currently under the impression that the definition of allocation and utilization might be inverted in

lapis/lapis/drone.py

Lines 88 to 96 in 989b805

def _init_allocation_and_utilisation(self):
levels = self.resources.levels
resources = []
for resource_key in self._valid_resource_keys:
resources.append(
getattr(levels, resource_key) / self.pool_resources[resource_key]
)
self._allocation = max(resources)
self._utilisation = min(resources)

As levels is aequivalent to the amount of unallocated resources on the machine, the allocation and utilization should be given by
self._allocation = min(resources) and self._utilisation = max(resources) respectively or am I mistaken?

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingquestionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions