Skip to content
This repository has been archived by the owner on Oct 5, 2022. It is now read-only.

Notification overflow #24

Open
MattIPv4 opened this issue Jun 8, 2019 · 1 comment
Open

Notification overflow #24

MattIPv4 opened this issue Jun 8, 2019 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@MattIPv4
Copy link
Owner

MattIPv4 commented Jun 8, 2019

Expected Behaviour

When too many notifications are generated than can fit on the page and the threshold is set to allow this, the system should allow for vertical scrolling through the notifications.

Current Behaviour

They overflow beyond the viewport and aren't accessible until higher up notifications are dismissed.

Development Environment

Safari Version 13.0 (15608.1.24.40.4)

Steps to Reproduce

  1. Load a test page with macOSNotifJS present.
  2. Set the threshold for the notifications to 100 before they will fade away.
    macOSNotifFadeThreshold = 100
  3. Spawn 100 notifications.
    for (var i = 0; i < 100; i++) { macOSNotif() }

Context

N/A

Additional Comments

N/A

@MattIPv4 MattIPv4 added the bug Something isn't working label Jun 8, 2019
@MattIPv4 MattIPv4 added this to the 1.0.0 milestone Jun 8, 2019
@MattIPv4
Copy link
Owner Author

MattIPv4 commented Jun 8, 2019

My thoughts on this for a fix are that all notifications need to be spawned within an mutual outer container that will spawn the full width/height of the viewport, this can then be set to allow vertical overflow which will in turn enable users to scroll through notifications when they have overflowed with the threshold too high.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant