Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhysiCell_settings-backup.xml concept is broken #259

Open
elmbeech opened this issue Jun 9, 2024 · 1 comment
Open

PhysiCell_settings-backup.xml concept is broken #259

elmbeech opened this issue Jun 9, 2024 · 1 comment

Comments

@elmbeech
Copy link
Contributor

elmbeech commented Jun 9, 2024

the Makefile reset function relies on a PhysiCell_settings-backup.xml file.
the problem is that not all sample project generate aPhysiCell_settings-backup.xml.
the bigger problem is that Makefile load function not generate at PhysiCell_settings-backup.xml.

as far as I can see, the PhysiCell_settings-backup.xml is only used by the reset function.

in my opinion, it would be wiser to have similar to the sample_projects/Makefile-default a sample_projects/PhysiCell_settings.xml-default and use this for the reset function.

@elmbeech
Copy link
Contributor Author

elmbeech commented Jun 9, 2024

The basic problem is now resolved in this pull request #244.
The Makefile reset function uses now sample_projects/PhysiCell_settings.xml-default to restore the initial condition.

I did not look into why some sample projects do make a PhysiCell_settings-backup.xml and some don't.
In my opinion, backups should be there just for safety. No code should rely on backups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant