Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FigureSeparator #20

Open
trevorspreadbury opened this issue Mar 31, 2022 · 0 comments
Open

Refactor FigureSeparator #20

trevorspreadbury opened this issue Mar 31, 2022 · 0 comments
Labels
enhancement New feature or request figure separator Relates to FigureSeperator low priority Describes a low priority issue

Comments

@trevorspreadbury
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
The FigureSeparator has grown to be somewhat clunky. It has components beyond just figure separation like scale detection. With the hopeful addition of new features, it would make sense to separate these into distinct tool subclasses.

Describe the solution you'd like
Creation of a ScaleDetector class as a subclass of ExsclaimTool

Describe alternatives you've considered
It is currently not broken so it seems lower priority. But it can definitely help the overall health of the codebase.
@trevorspreadbury trevorspreadbury added enhancement New feature or request low priority Describes a low priority issue figure separator Relates to FigureSeperator labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request figure separator Relates to FigureSeperator low priority Describes a low priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trevorspreadbury