-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: fails when Windows -> Linux #141
Comments
Hello @hearthewind ,
Any more details? Logs? Error message?
Both on the same network and no firewall in between?
That is bizarre.. maybe the Windows implementation is different... I don't have a Windows PC to analyze the packets unfortunately. Maybe someone with a Windows can check and try to fix this? I can help if needed, but help is welcome for that one. |
Hello @Martichou , I do have an windows PC and willing to help with the issue, if anyone will guide/help with analyzing packets |
Having the same problem. Neither I can detect Windows machine, nor Windows machine can detect Linux. Firewall on Linux is disabled. |
So I just tried this out. My setup is Linux - SteamOS, Android (Pixel) and Windows 10 PC. Sending/Receiving works both ways From Linux to Android & Android to Windows. |
I came here looking to see if there was an open issue for this- I'm experiencing it too: Stock Windows 11 PC install with SteamOS (Arch-ish) on a Steam Deck. Sending from SteamOS works but the file is renamed to a random number string and loses its extension. When sending from Windows to SteamOS, Windows can see the SteamOS recipient and makes an attempt to send but the SteamOS recipient never gets a confirmation to receive the file. |
I'm using the same setup (SteamDeck/Win11) (Using the official app from google on windows) (decktowin)desktop.log in the win to deck direction it tries to connect but never really does in both cases i sent a text file named test.txt containing text Let me know if my redactions were to aggressive and or i could help with more files/data |
I'm just gonna pitch in here since starting another thread is pointless. I can send files from Linux (Mint Wilma / Ubuntu Noble), but I can't receive them from the Windows host. And a weird thing is that the Windows and Linux entries appear multiple times in the other's window. Both RQuickShare (Linux) and the Windows app (the official Google one) cand send and receive fine from Android. |
I was able to fix one half of this problem: sending from Linux to Windows. Looking at rquickshare-master/core_lib/src/hdl/outbound.rs, I noticed that the PayloadHeader struct is missing some fields that Windows looks for when reconstructing the file. Specifically, the file_name field was not being set when constructing the PayloadHeader during file transfer. This caused the Windows receiver to default to numeric filenames, as it didn't receive the original filename from the sender. Here's the updated code with the fix: let payload_header = PayloadHeader { The file_name field extracts the original filename from curr_state.file_url using .file_name() This uses .unwrap() to assume that a filename is present Converts the filename to a UTF-8 String with .to_string_lossy().into_owned() Assigns it to the file_name field wrapped in Some() After applying this fix and recompiling the application, files sent from Linux to Windows now arrive with their correct filenames instead of random numeric junk. I still haven't looked into the send-stall when going the other direction. |
This change fixes issue Martichou#141 by including the file_name in the PayloadHeader when sending files. This allows Files sent from Linux to Windows to retain their names/extensions.
This change fixes issue Martichou#141 by including the file_name in the PayloadHeader when sending files. This allows Files sent from Linux to Windows to retain their names/extensions.
* fix: include file_name in PayloadHeader This change fixes issue #141 by including the file_name in the PayloadHeader when sending files. This allows Files sent from Linux to Windows to retain their names/extensions. * chore: file_name can be optional Signed-off-by: Martichou <[email protected]> --------- Signed-off-by: Martichou <[email protected]> Co-authored-by: Martichou <[email protected]>
Re: Windows to Linux file transfers- I've set up some more detailed logging and it looks like the encryption key data is missing on the receiving end right after initiating a transfer. I suspect possibly this is an issue with an invalid string from non-utf8 encoded data? Still digging. |
A new release has been made with the changes from @SalmonSays. Would it be possible for someone to report on what is still needed for this issue? :) |
I've tried 1.11.4 sending from linux causes the windows app to error out and the linux app to report a success Sending to an Android device works though in the reverse direction Receiving from Android works without problems Receiving from Windows works as long as the QuickShare app was started with Administrative privileges EDIT: Without any understanding of how the Protocol works: could this be related? |
I can confirm that v0.11.4 has broken functionality again between operating systems, I'll have to try adding some custom debugging when I have the free time to troubleshoot. My branch of v0.11.2 does not behave this way, so I'm assuming this is a result of some newly updated dependency/merged code? |
I am running Windows 11, Ubuntu 22.04 and Android 14.
I have multicast enabled, and use RQuickShare 0.10.2.
I can detect my Ubuntu device on my Android device, however, when I try to send anything to Ubuntu from Android, it fails.
I cannot detect my Ubuntu device on my Windows QuickShare app.
I tried to send some file from Ubuntu to WIndows, however, the received file on Windows will have a random file name, with '-' followed by a string of numbers, it will not be the same file name sent. The file extension will be lost as well. However, if we rename the file into the original extension, the file will still work.
Anyways, great work, I really have high hopes for this project, and I hope one day it works flawlessly.
The text was updated successfully, but these errors were encountered: