Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to connect with SSL when the server isn't setup for it #1

Open
ShermanGirl opened this issue Dec 27, 2018 · 1 comment
Open

Comments

@ShermanGirl
Copy link

I get the following message when trying to connect to a workserver that is not setup to accept ssl:

ERROR unrecognized cmd 3

Can an error be returned to the client?

@MarkReedZ
Copy link
Owner

I modified the asyncmrq tst.py to use SSL and our tst.py to not use SSL and I see a connection error in the client which I think is sufficient?

ConnectionAbortedError: SSL handshake is taking longer than 60.0 seconds: aborting the connection

The server however should not be printing an error message. I'm wondering if this is an issue with asyncio - perhaps it should not be passing an attempted SSL handshake through to our code. I'm going to recognize this case and drop it without printing an error for now. I have 3 thoughts. I'll close this issue after reviewing and completing 3.

  1. How do others handle this?

  2. I'll ask the asyncio guys if this is a bug.

  3. How should bad input in general be handled? We should return an error to the client as well as drop the connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants