Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans for onError and onExit? #7

Open
jopmiddelkamp opened this issue Jan 16, 2023 · 7 comments
Open

Plans for onError and onExit? #7

jopmiddelkamp opened this issue Jan 16, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@jopmiddelkamp
Copy link

Not an issue more of a question :) Do you plan to add some support for onError and onExit?

@Maksimka101 Maksimka101 added the enhancement New feature or request label Jan 16, 2023
@Maksimka101
Copy link
Owner

Hey👋

Are you talking about Combine or CombineWorker? CombineWorker is catching errors in the tasks, transfer them to the original isolate and throws them. So you can catch an error in the task this way:

try {
 await worker.execute(someTask);
} catch (e, st) {
  // Catch error from the `someTask`
}

@jopmiddelkamp
Copy link
Author

I was talking about the Combine. Would like to have as little as possible overhead but still be able to use plugins in my isolate. And the current package that I'm using doesn't support the onError and onExit either. So hoped it was on the roadmap in this project.

@Maksimka101
Copy link
Owner

If you need this feature, I'll implement it

@jopmiddelkamp
Copy link
Author

That would be great! Really appreciate it!

@Maksimka101
Copy link
Owner

Pr for this issue: #8

@jopmiddelkamp
Copy link
Author

Nice!

@Maksimka101
Copy link
Owner

Hello, @jopmiddelkamp

I have a problem with upgrading to the Flutter 3.7. Can you please comment issue #9?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants