-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inspect.iscoroutinefunction
returns false on pool -> connection -> execute
#1133
Comments
elprans
added a commit
that referenced
this issue
Mar 15, 2024
Use `markcoroutinefunction` (available in Python 3.12+) to make `inspect.iscoroutinefunction()` return the correct answer for wrapped connection methods. Fixes: #1133
This is fairly easy to fix, though the mechanism to inform |
elprans
added a commit
that referenced
this issue
Mar 15, 2024
Use `markcoroutinefunction` (available in Python 3.12+) to make `inspect.iscoroutinefunction()` return the correct answer for wrapped connection methods. Fixes: #1133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
the issue with a local PostgreSQL install?:
uvloop?: n/a
We noticed that some of our tests clean-up yield
RuntimeWarning: coroutine 'Connection.execute' was never awaited
when thePYTHONASYNCIODEBUG
envvar is set. While investigating, we found that this code in an unittest is the cause of the warning.The root cause is the
inspect.iscoroutinefunction
on a asyncpg pool connection instance returnsFalse
, causing theTestCase
class not to await it.https://github.com/python/cpython/blob/16349868d396cc1bff5188de3638321e87fe0293/Lib/unittest/async_case.py#L112-L120
When running this python snippet with
PYTHONASYNCIODEBUG=1
andPYTHONWARNINGS=once
and the output isExpectation is that both tests pass.
The text was updated successfully, but these errors were encountered: