-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guardian Angel damage absorption works in reverse #396
Comments
Hmm, I think the solution looks different. For the Guardian Angel the value should be +0.8, and the InputOperator needs to be changed to Multiply. |
That does look more correct. I've printed out all the references of To that end, I guess we gotta update the Harmony option that affects As for wings, they seem to be taking the negative addition approach. Shall we update wings to use the positive multiplicative calculation as well? OpenMU/src/Persistence/Initialization/VersionSeasonSix/Items/Wings.cs Lines 160 to 165 in 5602541
EDIT: Fix typos. |
I'm not sure how it's done at the original servers, but I think it makes sense to change that for wings as well. Then the behavior is constistent to the rest 😄 To fix that, not only the Initialization-code has to be changed. We also need update-code for existing databases. For these updates, we usually create plugins which implement |
Thanks for the heads-up. I'd agree that we can at least keep things consistent in OpenMU. I'll get a proper fix later. |
Hello @halflumi Is this still being looked over? |
@Niter88 Feel free to work on it. I doubt he is working on that a half year later :) |
@Niter88 Definitely take it if ya feel like it. I don't think I'll get the chance to work on OpenMU before the end of this year. |
Hey, I looked after this issue today. Changing the calculation of the wings and the soul barrier skill was a bit more complicated than I thought before. I had to extend the attribute system for that. My current state is at PR #456 😅 |
Describe the bug
Guardian Angel
makes characters take 20% more damage instead of 20% less.To Reproduce
Steps to reproduce the behavior:
Guardian Angel
equipped and take 119 points of damage.Expected behavior
Should take less damage with
Guardian Angel
equipped.Additional context
OpenMU/src/GameLogic/AttackableExtensions.cs
Lines 78 to 81 in 6b93306
Stats.DamageReceiveDecrement
seems to be working fine. During the repro,defender.Attributes[Stats.DamageReceiveDecrement]
has a value of0.44617185
without equippingGuardian Angel
and0.60272336
with it equipped.Modifying
Guardian Angel
'sDamage Receive Multiplier
value from 0.2 to -0.2 seems to fix the issue. NowStats.DamageReceiveDecrement
is changed from0.44617185
to0.28962034
when equippingGuardian Angel
.The issue seems to be universal to items with positive
Damage Receive Multiplier
modifiers. For example,Horn of Dinorant
is supposed to absorb 10% of the damage, but it changesStats.DamageReceiveDecrement
from 1.0 to 1.1.To that end, I guess the sensible fix is to change all positive
Damage Receive Multiplier
to negative for all erroneous items. Though I'm not sure if that's the best fix. Any thoughts on this?The text was updated successfully, but these errors were encountered: