Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review [ONGOING] #38

Open
3 tasks
venexia opened this issue Dec 6, 2024 · 0 comments
Open
3 tasks

Code review [ONGOING] #38

venexia opened this issue Dec 6, 2024 · 0 comments

Comments

@venexia
Copy link

venexia commented Dec 6, 2024

  • Covariate file name. The wiki/Data-preparation#covariate-data says the static covariates file will be called pheno_covariates.txt but it is later referred to as static_covariates.txt.
  • Simplify the numbering of steps. There is currently data preparation, setup, step 00, step 01, ... step 04. I think it would be more intuitive to number these as seven steps and make it clear whether data preparation should be done before or after setup.
  • Provide a full variable list. It would have been helpful to have a full list of variables in one place, where an indicator for required/optional. I found myself reading through all the data preparation and making my own list of age, sex, BMI, etc. to perform the initial extract from the data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant