Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No documentation for how to use cylindrical and axisymmetric coordinates #278

Open
wilfonba opened this issue Dec 26, 2023 · 6 comments
Open
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers question Further information is requested

Comments

@wilfonba
Copy link
Collaborator

There is no documentation on how to run simulations using cylindrical and axisymmetric coordinates. There are several intricacies to using cylindrical coordinates (and I assume axisymmetric coordinates) that I've come across when trying to run a 3D pipe flow. Perhaps an additional appendix to the case file documentation would best alleviate this? This isn't a commonly used feature, but it should be documented nonetheless. There should probably be an appendix in the flow visualization documentation detailing how to perform the coordinate transformations correctly as well as it's not as obvious as one might think.

@sbryngelson sbryngelson added the documentation Improvements or additions to documentation label Jan 4, 2024
@sbryngelson
Copy link
Member

Is this still open or no @wilfonba ?

@wilfonba
Copy link
Collaborator Author

Still open

@sbryngelson sbryngelson added enhancement New feature or request good first issue Good for newcomers question Further information is requested labels May 28, 2024
@sbryngelson
Copy link
Member

@ChrisZYJ I cannot remember if you added documentation for this or not. Can you remind me?

@ChrisZYJ
Copy link
Contributor

ChrisZYJ commented Jul 27, 2024

@sbryngelson I fixed 2D axisymmetric and added detailed documentation for it. For the 3D cylindrical coordinates, I wasn't able to get it working (its previous implementation was actually for 2D axisymmetric), so I removed it from the documentation. I intentionally left a few gaps in the Acoustic Supports label numbering to allow for future additions if someone manages to fix the 3D cylindrical coordinates implementation.

@sbryngelson
Copy link
Member

@ChrisZYJ I meant for 3D cylindrical coordinates without any acoustic source. These should work; they just aren't documented. I thought maybe you added documentation for them.

@ChrisZYJ
Copy link
Contributor

Sorry I didn't read the thread properly. No, I didn't manage to get it working. Was also wondering where the documentation is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers question Further information is requested
Development

No branches or pull requests

3 participants