Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Error] Exit status seems to not be evaluated for every single instruction of PKGBUILD functions #50

Closed
M0Rf30 opened this issue Dec 19, 2023 · 0 comments
Closed

[Error] Exit status seems to not be evaluated for every single instruction of PKGBUILD functions #50

M0Rf30 opened this issue Dec 19, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@M0Rf30
Copy link
Owner

M0Rf30 commented Dec 19, 2023

Describe the bug
Seems that only last instruction exit status is evaluated from mvdan/sh in packaga and build functions, giving a misleading packaging result

To Reproduce
Use more than one command and put a failing install in the middle. install will fail but package will be created

Expected behavior
install command fails giving an error on package creation and exiting from yap with exit-code = 1

Reported by @frisonisland
@M0Rf30 M0Rf30 added the bug Something isn't working label Dec 19, 2023
@M0Rf30 M0Rf30 closed this as completed in 1e12482 Dec 31, 2023
M0Rf30 added a commit that referenced this issue Dec 31, 2023
@M0Rf30
fix: exit immediately if a command exits with a non-zero status (close …
e4254dc 
…#50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@M0Rf30