chore: de-duplicate package managers args

Author: M0Rf30

pkg/abuild/abuild.go

@@ -73,12 +73,9 @@ func (a *Apk) Install(artifactsPath string) error {
 		".apk"
 
 	pkgFilePath := filepath.Join(artifactsPath, a.PKGBUILD.PkgName, a.PKGBUILD.ArchComputed, pkgName)
+	args := append(installArgs, pkgFilePath)
 
-	if err := utils.Exec(true,
-		"apk",
-		"add",
-		"--allow-untrusted",
-		pkgFilePath); err != nil {
+	if err := utils.Exec(true, "", "apk", args...); err != nil {
 		return err
 	}
 
@@ -90,21 +87,14 @@ func (a *Apk) Install(artifactsPath string) error {
 // makeDepends is a slice of strings representing the dependencies to be added.
 // It returns an error if there is any issue with adding the dependencies.
 func (a *Apk) Prepare(makeDepends []string) error {
-	args := []string{
-		"add",
-	}
-
-	return a.PKGBUILD.GetDepends("apk", args, makeDepends)
+	return a.PKGBUILD.GetDepends("apk", installArgs, makeDepends)
 }
 
 // PrepareEnvironment prepares the build environment for APK packaging.
 // It installs requested Go tools if 'golang' is true.
 // It returns an error if any step fails.
 func (a *Apk) PrepareEnvironment(golang bool) error {
-	args := []string{
-		"add",
-	}
-	args = append(args, buildEnvironmentDeps...)
+	args := append(installArgs, buildEnvironmentDeps...)
 
 	if golang {
 		utils.CheckGO()

pkg/abuild/constants.go

@@ -1,5 +1,10 @@
 package abuild
 
+var installArgs = []string{
+	"add",
+	"--allow-untrusted",
+}
+
 var (
 	APKArchs = map[string]string{
 		"x86_64":  "x86_64",
@@ -67,7 +72,7 @@ arch="{{.ArchComputed}}"
 {{- end}}
 {{- if .Depends}}
 depends="
-{{ range .Depends }}{{ . }} 
+{{ range .Depends }}{{ . }}
 {{ end }}"
 {{- end }}
 {{- if .URL}}

pkg/dpkg/constants.go

@@ -16,6 +16,12 @@ var buildEnvironmentDeps = []string{
 	"tzdata",
 }
 
+var installArgs = []string{
+	"--allow-downgrades",
+	"--assume-yes",
+	"install",
+}
+
 var DebArchs = map[string]string{
 	"any":     "all",
 	"x86_64":  "amd64",

pkg/dpkg/dpkg.go

@@ -73,7 +73,9 @@ func (d *Deb) Install(artifactsPath string) error {
 			d.PKGBUILD.PkgName, d.PKGBUILD.PkgVer, d.PKGBUILD.PkgRel,
 			d.PKGBUILD.ArchComputed))
 
-	if err := utils.Exec(false, "", "apt-get", "install", "-y", artifactFilePath); err != nil {
+	args := append(installArgs, artifactFilePath)
+
+	if err := utils.Exec(false, "", "apt-get", args...); err != nil {
 		return err
 	}
 
@@ -85,25 +87,15 @@ func (d *Deb) Install(artifactsPath string) error {
 // makeDepends: a slice of strings representing the dependencies to be installed.
 // Returns an error if there was a problem installing the dependencies.
 func (d *Deb) Prepare(makeDepends []string) error {
-	args := []string{
-		"--allow-downgrades",
-		"--assume-yes",
-		"install",
-	}
-
-	return d.PKGBUILD.GetDepends("apt-get", args, makeDepends)
+	return d.PKGBUILD.GetDepends("apt-get", installArgs, makeDepends)
 }
 
 // PrepareEnvironment prepares the environment for the Deb package.
 //
 // It takes a boolean parameter `golang` which indicates whether or not to set up Go.
 // It returns an error if there was a problem during the environment preparation.
 func (d *Deb) PrepareEnvironment(golang bool) error {
-	args := []string{
-		"--assume-yes",
-		"install",
-	}
-	args = append(args, buildEnvironmentDeps...)
+	args := append(installArgs, buildEnvironmentDeps...)
 
 	if err := utils.Exec(false, "", "apt-get", args...); err != nil {
 		return err

pkg/makepkg/constants.go

@@ -101,6 +101,11 @@ const dotMtree = `#mtree
 {{- end }}
 `
 
+var installArgs = []string{
+	"-S",
+	"--noconfirm",
+}
+
 const postInstall = `
 {{- if .PreInst}}
 pre_install() {

pkg/makepkg/makepkg.go

@@ -169,24 +169,15 @@ func (m *Pkg) Install(artifactsPath string) error {
 // makeDepends is a slice of strings representing the dependencies to be included.
 // It returns an error if there is any issue getting the dependencies.
 func (m *Pkg) Prepare(makeDepends []string) error {
-	args := []string{
-		"-S",
-		"--noconfirm",
-	}
-
-	return m.PKGBUILD.GetDepends("pacman", args, makeDepends)
+	return m.PKGBUILD.GetDepends("pacman", installArgs, makeDepends)
 }
 
 // PrepareEnvironment prepares the environment for the Makepkg.
 //
 // It takes a boolean parameter `golang` which indicates whether the environment should be prepared for Golang.
 // It returns an error if there is any issue in preparing the environment.
 func (m *Pkg) PrepareEnvironment(golang bool) error {
-	args := []string{
-		"-S",
-		"--noconfirm",
-	}
-	args = append(args, buildEnvironmentDeps...)
+	args := append(installArgs, buildEnvironmentDeps...)
 
 	if golang {
 		utils.CheckGO()

pkg/rpm/constants.go

@@ -24,6 +24,11 @@ var buildEnvironmentDeps = []string{
 	"which",
 }
 
+var installArgs = []string{
+	"-y",
+	"install",
+}
+
 var (
 	RPMArchs = map[string]string{
 		"x86_64":  "x86_64",

pkg/rpm/rpm.go

@@ -123,12 +123,9 @@ func (r *RPM) Install(artifactsPath string) error {
 		".rpm"
 
 	pkgFilePath := filepath.Join(artifactsPath, pkgName)
+	args := append(installArgs, pkgFilePath)
 
-	if err := utils.Exec(false, "",
-		"dnf",
-		"install",
-		"-y",
-		pkgFilePath); err != nil {
+	if err := utils.Exec(false, "", "dnf", args...); err != nil {
 		return err
 	}
 
@@ -140,24 +137,15 @@ func (r *RPM) Install(artifactsPath string) error {
 // makeDepends is a slice of strings representing the dependencies to be installed.
 // It returns an error if there is any issue during the installation process.
 func (r *RPM) Prepare(makeDepends []string) error {
-	args := []string{
-		"-y",
-		"install",
-	}
-
-	return r.PKGBUILD.GetDepends("dnf", args, makeDepends)
+	return r.PKGBUILD.GetDepends("dnf", installArgs, makeDepends)
 }
 
 // PrepareEnvironment prepares the environment for the RPM struct.
 //
 // It takes a boolean parameter `golang` which indicates whether or not to set up the Go environment.
 // It returns an error if there was an issue with the environment preparation.
 func (r *RPM) PrepareEnvironment(golang bool) error {
-	args := []string{
-		"-y",
-		"install",
-	}
-	args = append(args, buildEnvironmentDeps...)
+	args := append(installArgs, buildEnvironmentDeps...)
 
 	if err := utils.Exec(false, "", "dnf", args...); err != nil {
 		return err