-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds faililng due to incorrect dummy files generated for benches #203
Comments
This is related to #150 and it can be solved by using Thanks for reporting it! |
@LukeMathWalker Using target detection from The problem only happens when user code is copied over and then there are two copies of the same benchmark file, which causes conflicts. Maybe it would be enough to just delete the |
@Kobzol that's indeed the workaround I've adopted so far (doing another pass to rm the wrong files). |
Cargo allows benchmarks to be created with two possible filesystem layouts:
benches/<benchfile.rs>
benches/<benchmark>/{main.rs, <other rust files>}
.See for example: https://github.com/vmware/database-stream-processor/tree/main/crates/dbsp/benches
Using cargo chef on such a project structure creates skeletons of type 1) for benchmark layouts of type 2), causing builds to fail with errors like:
In this example,
benches/ldbc-graphalytics.rs
is the created dummy file.The text was updated successfully, but these errors were encountered: