output includes readline buffer?

[electricplant]

Hey,

This is probably a bit of a silly issue, but I'm really stumped on how to fix it. It seems like the output is being copied somehow? This is after I noticed the whole pwd was being copied over as well.

I removed all the prompts and anything that prints besides the necessary output, that didn't fix it unfortunately.

Any help would be appreciated. I am just trying to make sure my project is 100%

[MrSloth-dev]

Hello, this is related to the file descriptors that you are passing. I did a fork and some people got the same code and you in my tests but in another computer the tests were passing, I'm still learning to try to decipher why sends the prompt ( in my case I got a tests that send the hostname and pwd into the file descriptor) but I think it has to be related to the small delays in the builtin execution that aren't caught up in the redirections...

[LucasKuhn]

The way the tester works is by sending the test line to your minishell executable, eg:

line="echo hello world"
echo -e "$line" | ./minishell 2> /dev/null

+ some extra shenanigans where the tester tries to remove your prompt.

The whole idea is to pipe some commands to your executable and we expect that the result is the same as bash

echo -e 'echo 42' | ./minishell
echo -e 'echo 42' | bash
# both outputs should be the same

I would try something like echo -e 'echo 42' | ./minishell and see how it responds

Also, @MrSloth-dev , if you did a fork and fixed this with a better script please feel free to open a PR 🙏

[MrSloth-dev]

@LucasKuhn I already did a while ago when added valgrind to the tests, maybe next week I reformulate the PR and try again :)

[electricplant]

Ah, thank you! I had completely forgotten about non-interactive mode... I will go implement it now and I'm sure it will work then