Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external palettes in injection files #1521

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Support external palettes in injection files #1521

merged 3 commits into from
Sep 14, 2024

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Sep 14, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

Resolves #1520. Improves the execution plan for #1506.

Before After
20240914_212813_Lost_Valley_before 20240914_212836_Lost_Valley_after
20240914_213053_Colosseum_before 20240914_213106_Colosseum_after

@rr- rr- added the Enhancement Improvement of an existing feature label Sep 14, 2024
@rr- rr- added this to the 4.4 milestone Sep 14, 2024
@rr- rr- self-assigned this Sep 14, 2024
@rr- rr- requested review from a team as code owners September 14, 2024 19:35
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team September 14, 2024 19:35
Copy link
Collaborator

@walkawayy walkawayy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skyboxes look good, but I'm no expert in the injection code. LGTM?

Copy link
Collaborator

@lahm86 lahm86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. Everything looks great ❤️

@rr- rr- merged commit 5750b06 into develop Sep 14, 2024
6 checks passed
@rr- rr- deleted the true-color branch September 14, 2024 21:14
@rr- rr- added the TR1 label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement of an existing feature TR1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Enhancement: let injected content introduce own palettes
4 participants