Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure-Element Preprocessor definition ifndef wrapping #1592

Open
bdesterBE opened this issue Jan 4, 2024 · 1 comment
Open

Secure-Element Preprocessor definition ifndef wrapping #1592

bdesterBE opened this issue Jan 4, 2024 · 1 comment

Comments

@bdesterBE
Copy link

Hello,

I would like to open a pull request to simply wrap each define in src/peripherals/soft-se/se-identity.h with #ifndef tags. For example:

/*!
 * App/Join server IEEE EUI (big endian)
 */
#ifndef LORAWAN_JOIN_EUI
#define LORAWAN_JOIN_EUI
#endif

This would allow users to overwrite these values from application level CMakeLists.txt files without a warning being produced, and removes the need to modify LoRaMac-node directly with hard-coded values when it is being used as a submodule.

Thanks,
Brandon

@pjb-loxius
Copy link

pjb-loxius commented Jan 4, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants