You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that if the call to NvmDataMgmtStore at src/apps/LoRaMac/common/LmHandler/LmHandler.c line 389 blocks while the radio is transmitting, the transmitter will stay on. This can cause problems with various radio transmission dwell-time limits (for example, the limit for the US915 region is 400 ms), and means that the radio transmission duty cycle is higher than expected.
Our internal fix for this is to check that the radio is not transmitting before trying to write to NVM:
if ( Radio.GetStatus( ) != RF_TX_RUNNING )
{
// Store to NVM if required
size = NvmDataMgmtStore( );
if( size > 0 )
{
if( LmHandlerCallbacks->OnNvmDataChange != NULL )
{
LmHandlerCallbacks->OnNvmDataChange( LORAMAC_HANDLER_NVM_STORE, size );
}
}
}
If you think this is an acceptable fix, I can do a pull request if you want.
The text was updated successfully, but these errors were encountered:
Hi,
I noticed that if the call to NvmDataMgmtStore at src/apps/LoRaMac/common/LmHandler/LmHandler.c line 389 blocks while the radio is transmitting, the transmitter will stay on. This can cause problems with various radio transmission dwell-time limits (for example, the limit for the US915 region is 400 ms), and means that the radio transmission duty cycle is higher than expected.
Our internal fix for this is to check that the radio is not transmitting before trying to write to NVM:
If you think this is an acceptable fix, I can do a pull request if you want.
The text was updated successfully, but these errors were encountered: